fix: build universal binary (arm64 + x86_64) - #1
Open
beznazwiska wants to merge 1 commit into
Open
Conversation
The previous build script hardcoded `-target arm64-apple-macos13.0`, producing an Apple Silicon-only binary. Intel Macs failed with "bad CPU type in executable" (NSError -10661). This change compiles for both architectures separately and merges them via `lipo` into a single universal binary. Verified on macOS 13.7 Ventura (Intel). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
build.shhardcodes-target arm64-apple-macos13.0, producing an Apple Silicon-only binary. On Intel Macs the app fails to launch with:The
opencommand returnsNSOSStatusErrorDomain Code=-10661, giving no clear indication that architecture is the root cause.Solution
Build separate binaries for both architectures and merge them into a single universal binary via
lipo:Additional improvements:
lipoTesting
Verified on macOS 13.7 Ventura (Intel x86_64):
build.shcompletes successfullyMach-O universal binary with 2 architectures: [x86_64] [arm64]Compatibility
install.shworks unchanged (callsbuild.shinternally)