refactor: use lsp_check_applicable command - #269
Merged
Conversation
rchl
marked this pull request as draft
February 26, 2026 21:20
Member
Author
|
Let's hold off with this. I think there is a bug with that command (it overrides @jwortmann I have set |
Member
Yes, I didn't consider someone running the command while the config is disabled. We should probably add a check if not config.enabled:
returnafter these lines |
rchl
marked this pull request as ready for review
March 28, 2026 14:45
Member
Author
|
This is ready. The fix for LSP will be released soon but it's not a blocker anyway. |
Collaborator
|
This is a simple PR. LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LSP had a
lsp_check_applicablecommand for a while to handle copilot use case.Minor type fixes in the process.