Skip to content

refactor: use lsp_check_applicable command - #269

Merged
rchl merged 2 commits into
masterfrom
fix/is-applicable
Mar 28, 2026
Merged

refactor: use lsp_check_applicable command#269
rchl merged 2 commits into
masterfrom
fix/is-applicable

Conversation

@rchl

@rchl rchl commented Feb 26, 2026

Copy link
Copy Markdown
Member

LSP had a lsp_check_applicable command for a while to handle copilot use case.

Minor type fixes in the process.

@rchl
rchl marked this pull request as draft February 26, 2026 21:20
@rchl

rchl commented Feb 26, 2026

Copy link
Copy Markdown
Member Author

Let's hold off with this. I think there is a bug with that command (it overrides enabled: false).

@jwortmann I have set enabled: false globally for copilot but the lsp_check_applicable command actually makes it start still.

@jwortmann

Copy link
Copy Markdown
Member

@jwortmann I have set enabled: false globally for copilot but the lsp_check_applicable command actually makes it start still.

Yes, I didn't consider someone running the command while the config is disabled. We should probably add a check

if not config.enabled:
    return

after these lines
https://github.com/sublimelsp/LSP/blob/ead1085da645c6ad71e2efa9a3104b276502e605/plugin/core/registry.py#L239-L242

@rchl rchl changed the title refactor: use LspCheckApplicableCommand refactor: use lsp_check_applicable command Feb 27, 2026
@rchl
rchl marked this pull request as ready for review March 28, 2026 14:45
@rchl

rchl commented Mar 28, 2026

Copy link
Copy Markdown
Member Author

This is ready. The fix for LSP will be released soon but it's not a blocker anyway.

@jfcherng

Copy link
Copy Markdown
Collaborator

This is a simple PR. LGTM.

@rchl
rchl merged commit 7bd9d75 into master Mar 28, 2026
2 checks passed
@rchl
rchl deleted the fix/is-applicable branch March 28, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants