refactor: mgrating from AbstractPlugin to LspPlugin - #283
Merged
Conversation
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
- Replace AbstractPlugin base class with LspPlugin - Consolidate 5 lifecycle methods into on_pre_start_async - Replace register_plugin/unregister_plugin with classmethods - Replace storage_path() with ST_STORAGE_PATH constant - Migrate on_settings_changed to on_initialized_async - Rename is_applicable to is_applicable_async with IsApplicableContext See https://lsp.sublimetext.io/migrating_to_lsp_plugin/ Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Jack Cherng <jfcherng@gmail.com>
rchl
reviewed
May 22, 2026
Member
There was a problem hiding this comment.
Some notes:
VersionManagercould get the package storage path fromCopilotPlugin.plugin_storage_path. Just to have a single source of truth for the path.- TextCommands don't need SESSION_NAME to be set anymore
get_plugin_settingis unusedget_plugin_setting_dottedis only used to read the debug setting which feels a bit overkill to me. Especially as it's the only reason thatjmespathis required. Also note that thedebugsetting is not a server settings so it would be better to have it in the root of the configuration file rather than insettings.*. One reason is that the server doesn't care about this setting and another is that changing settings in the root restarts the server while changingsettingsdoesn't.
rchl
reviewed
May 22, 2026
Co-authored-by: Rafał Chłodnicki <rchl2k@gmail.com>
Co-authored-by: Rafał Chłodnicki <rchl2k@gmail.com>
Co-authored-by: Rafał Chłodnicki <rchl2k@gmail.com>
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
Collaborator
Author
For historical reason, almost all settings in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://lsp.sublimetext.io/migrating_to_lsp_plugin/