Skip to content

chore(types): fix wrong type #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfcherng merged 4 commits into from
Jul 2, 2026
Merged

chore(types): fix wrong type #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c5ff31d
chore(types): fix wrong type
rchl Jun 30, 2026
cee1647
layout not supported for show_popup
rchl Jul 1, 2026
7cf2de2
align basedpyright and pyright
rchl Jul 2, 2026
2a40b4e
fix types when not using included typings
rchl Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions plugin/ui/chat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,8 @@ def update(self) -> None:
"""Update the conversation sheet content."""
if not (sheet := self.window.transient_sheet_in_group(self.manager.group_id)):
return
if not isinstance(sheet, sublime.HtmlSheet):
return

mdpopups.update_html_sheet(sheet=sheet, contents=self.completion_content, md=True, wrapper_class="wrapper")

Expand All @@ -194,7 +196,7 @@ def close(self) -> None:
self.manager.is_visible = False
self.manager.window.run_command("hide_panel")
if self.manager.original_layout:
self.window.set_layout(self.manager.original_layout)
self.window.set_layout(self.manager.original_layout) # pyright: ignore[reportArgumentType]

@rchl rchl Jul 2, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a problem when testing in LSP repo - https://github.com/sublimelsp/LSP/actions/runs/28530627354/job/84578855392

The types of ST layout are:

  • custom Layout in LSP-copilot stubs
  • dict[str, Any] in LSP stubs
  • dict[str, Value] in ST's own types

So it's all a mess that's why I'm just ignoring those issues.

self.manager.original_layout = None

if view := self.window.active_view():
Expand All @@ -217,7 +219,7 @@ def _open_in_group(self, window: sublime.Window, group_id: int) -> None:

def _open_in_side_by_side(self, window: sublime.Window) -> None:
"""Open the conversation sheet in side-by-side layout."""
self.manager.original_layout = window.layout()
self.manager.original_layout = window.layout() # pyright: ignore[reportAttributeAccessIssue]
window.set_layout({
"cols": [0.0, 0.5, 1.0],
"rows": [0.0, 1.0],
Expand Down
1 change: 0 additions & 1 deletion plugin/ui/completion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,6 @@ def show(self) -> None:
view=self.view,
content=self.popup_content,
md=True,
layout=sublime.LAYOUT_INLINE,
flags=sublime.COOPERATE_WITH_AUTO_COMPLETE,
max_width=640,
)
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ ignore = [
]
stubPath = 'typings'
pythonVersion = '3.8'
typeCheckingMode = 'standard'

[tool.ruff]
preview = true
Expand Down
Loading