Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release] 20240410-2 #60

Merged
merged 1 commit into from
Apr 10, 2024
Merged

[release] 20240410-2 #60

merged 1 commit into from
Apr 10, 2024

Conversation

jiqiang90
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have tested locally
  • I have performed a self review of my changes
  • Updated any relevant documentation
  • Linked to any relevant issues
  • I have added tests relevant to my changes
  • Any dependent changes have been merged and published in downstream modules
  • My code is up to date with the base branch
  • I have updated relevant changelogs. We suggest using chan

@stwiname stwiname merged commit 1c70806 into main Apr 10, 2024
2 of 3 checks passed
Copy link
Contributor

Coverage report

Caution

Test run failed

St.
Category Percentage Covered / Total
🔴 Statements 36.54% 1615/4420
🟡 Branches 64.16% 145/226
🔴 Functions 37.11% 59/159
🔴 Lines 36.54% 1615/4420

Test suite run failed

Failed tests: 1/68. Failed suites: 1/7.
  ● StellarApi › handleError - soroban node been reset

    expect(received).rejects.toThrow(expected)

    Expected pattern: /Not Found/
    Received message: "Gone"

          276 |     sequence: number,
          277 |   ): Promise<IBlock<StellarBlockWrapper>> {
        > 278 |     const [ledger, transactions, operations, effects] = await Promise.all([
              |                                                         ^
          279 |       this.api.ledgers().ledger(sequence).call(),
          280 |       this.fetchTransactionsForLedger(sequence),
          281 |       this.fetchOperationsForLedger(sequence),

      at _callee6$ (node_modules/stellar-sdk/lib/horizon/call_builder.js:341:64)
      at tryCatch (node_modules/stellar-sdk/lib/horizon/call_builder.js:14:913)
      at Generator.<anonymous> (node_modules/stellar-sdk/lib/horizon/call_builder.js:14:2863)
      at Generator.next (node_modules/stellar-sdk/lib/horizon/call_builder.js:14:1550)
      at asyncGeneratorStep (node_modules/stellar-sdk/lib/horizon/call_builder.js:15:103)
      at _next (node_modules/stellar-sdk/lib/horizon/call_builder.js:16:194)
      at node_modules/stellar-sdk/lib/horizon/call_builder.js:16:364
      at node_modules/stellar-sdk/lib/horizon/call_builder.js:16:97
      at _handleNetworkError (node_modules/stellar-sdk/lib/horizon/call_builder.js:354:37)
                at async Promise.all (index 0)
      at StellarApi.fetchAndWrapLedger (packages/node/src/stellar/api.stellar.ts:278:57)
      at Object.<anonymous> (packages/node/src/stellar/api.stellar.spec.ts:96:5)
      at Object.toThrow (node_modules/expect/build/index.js:218:22)
      at Object.<anonymous> (packages/node/src/stellar/api.stellar.spec.ts:96:71)

Report generated by 🧪jest coverage report action from 8a57eab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants