feat: refactor and improve internals relating to simple extensions #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvanstraten
force-pushed
the
extension-refactor
branch
3 times, most recently
from
9f9622b to
5f0b299
Compare
BREAKING CHANGE: various substrait_validator::output types relating to extensions have changed. Name resolution diagnostic messages and codes also changed, for as far as these were implemented before.
jvanstraten
force-pushed
the
extension-refactor
branch
from
5f0b299 to
ebec6c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The driving change here is a new namespace and name resolution system with support for:
.for the namespace separator.There's a bunch of cleanup in here as well, in preparation for #43 and the actual implementation of extension parsing after that.
BREAKING CHANGE: various substrait_validator::output types relating to extensions have changed. Name resolution diagnostic messages and codes also changed, for as far as these were implemented before.