feat: add skip_nulls option to scalar aggregate functions #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jacques-n
reviewed
Nov 30, 2022
| @@ -756,6 +756,8 @@ aggregate_functions: | |||
| options: | |||
| overflow: | |||
| values: [ SILENT, SATURATE, ERROR ] | |||
| skip_nulls: | |||
There was a problem hiding this comment.
I'm wondering if we should add this property to the aggregate function invocation as opposed to every aggregate function. It feels kind of like aggregate input sorting or some other function-impl independent concept. Thoughts @westonpace @gforsyth ?
There was a problem hiding this comment.
I agree that if we're specifying an option for every function definition that we should move it up to the invocation
There was a problem hiding this comment.
That makes sense, will close this PR and have opened #401 instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
skip_nullsoption to each of the scalar aggregate functions, with a default value ofTRUE(which would just replicate existing behaviour) for all of these functions except forquantile()which had the previous behaviour of returningNULLif any input values areNULL.Although some backends remove NULL values by default in computations, others allow specifying this option to return an NULL value if any of the input values are NULL.
Now I've done this, I'm wondering if this is something relevant to the
NULLABILITY HANDLINGfield, but if I'm completely honest I still don't understand it after reading the docs (that said, I'm happy to submit another PR updating the docs for that section if someone reviewing this explains it to me!) I don't think that's relevant here, though I'm not sure.