fix: correct dependency field names in beads tracker#131
fix: correct dependency field names in beads tracker#131roberto-mello wants to merge 4 commits intosubsy:mainfrom
Conversation
The BeadJson interface had incorrect field names for dependencies that didn't match the actual bd list --json output: - dependencies[].id -> dependencies[].depends_on_id - dependencies[].dependency_type -> dependencies[].type This caused dependsOn to never be populated, making all tasks appear as "actionable" instead of properly detecting blocked tasks.
|
@roberto-mello is attempting to deploy a commit to the plgeek Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe Beads tracker plugin's dependency object structure is refactored, renaming fields ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/plugins/trackers/builtin/beads/index.ts (1)
48-53: Bothdependenciesanddependentsshould be simple string arrays of issue IDs, not objects.According to bd CLI documentation, both
dependenciesanddependentsfields should contain arrays of issue ID strings (e.g.,["bd-xxxx", "bd-yyyy"]), not arrays of objects withid,title,status, anddependency_typefields. Update the type definitions for both fields to match the actual bd CLI output structure:dependencies?: string[]anddependents?: string[].
|
This PR changes the field names to match the raw storage format in issues.jsonl, but the code actually parses bd show --json output, which returns a different (expanded) format:
The current code on main is correct I think. Merging this would break dependency parsing since dep.depends_on_id and dep.type would be undefined in the actual CLI output.Let me know if you think I'm missing something here. |
Summary
bd list --jsonoutputProblem
The BeadJson interface had incorrect field names for dependencies that didn't match the actual bd output:
dependencies[].idshould bedependencies[].depends_on_iddependencies[].dependency_typeshould bedependencies[].typeThis caused
dependsOnto never be populated, making all tasks appear as "actionable" instead of properly detecting blocked tasks. The TUI would show blocked tasks as ready to work on.Tests ran
bun run typecheckpassesbun run buildpassesralph-tui run --epic <epic-id>with tasks that have blocking dependenciesSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.