Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing regression in Music keyboard widget block with alignment of blocks #2844

Merged

Conversation

ksraj123
Copy link
Member

When hertz or pitch blocks are added to the music keyboard widget through the widget window then ideally the newly generated blocks should connect and align properly with the existing blocks in the clamp of the widget block but this it shows regression.

Before -

MBRegression.mp4

After -

fixing.regression.in.musicblocks.widgetblock.mov

References

Please share feedback and suggestions. Thanks

@walterbender
Copy link
Member

There seem to be to more "regressions":
(1) the + pie menu is not closed when the widget is closed;
(2) see the attached (after adding a few notes and reopening the widget, an extra octave (to the left) is added for some reason.
Screenshot from 2021-02-15 10-39-06

@ksraj123
Copy link
Member Author

Came across another regression, the location of the pie menu which appears on clicking the add button is wrong (fixed).

regression - music keyboard pie menu at wrong location

@walterbender
Copy link
Member

Thanks for fixing the problem with the piemenu.
I think I understand why the extra keys are added when you add a hertz block -- the block that is added, 291, is rounded down from C4, so it is one octave lower than any of the keys on the default keyboard. Rounding up fixes the problem.

@walterbender walterbender merged commit cb1ee81 into sugarlabs:master Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants