Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

languages updated for grid #3310

Merged
merged 10 commits into from
Aug 6, 2023
Merged

languages updated for grid #3310

merged 10 commits into from
Aug 6, 2023

Conversation

shishirkj
Copy link
Contributor

issue #3305 ,the issue was the grid was not being converted in different language.
The issue was in localization.in file had to add few lines change it to particular languages.

@shishirkj
Copy link
Contributor Author

i think after u review this i will push previous PR for PNG file in documentation as 😓facing difficulty in creating both PR seperately

@shishirkj
Copy link
Contributor Author

i have made some changes in po directory and translated few words

@@ -1177,7 +1177,7 @@ msgstr "ninguno"
#: js/block.js:3470
#: js/ExtrasBlocks.js:422
msgid "treble"
msgstr "treble"
msgstr "agudos"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know this word.

po/ja.po Outdated

#: js/activity.js:1668
msgid "chord name"
msgid ""chord name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be fixed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont how but i had fixed this issue as it was ther before 😓,i will fix these issues ASAP

ignore this one
js/blocks/ExtrasBlocks.js Outdated Show resolved Hide resolved
po/sw.po Outdated
@@ -2536,7 +2536,7 @@ msgstr ""

#: js/palette.js:569
msgid "grid"
msgstr ""
msgstr " Gridi"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an extra space at the beginning of the word?

po/sw.po Outdated
@@ -2379,7 +2379,7 @@ msgstr ""

#: js/turtles.js:848
msgid "Grid"
msgstr ""
msgstr " Gridi"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an extra space at the beginning of the word?

po/nl.po Outdated
@@ -2534,7 +2534,7 @@ msgstr ""

#: js/palette.js:569
msgid "grid"
msgstr ""
msgstr "Rooster "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an extra space at the end of the word?

po/nl.po Outdated
@@ -2377,7 +2377,7 @@ msgstr ""

#: js/turtles.js:848
msgid "Grid"
msgstr ""
msgstr "Rooster "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an extra space at the end of the word?

po/ja.po Outdated

#: js/activity.js:1668
msgid "chord name"
msgid ""chord name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This (misplaced quote) still needs to be fixed.

po/ja.po Outdated
@@ -274,7 +274,7 @@ msgstr "音色サンプル"

#: js/turtles.js:848
msgid "Grid"
msgstr ""
msgstr " グリッド"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an extra space at the beginning of the word?

Copy link
Member

@walterbender walterbender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a few minor fixes needed.

@shishirkj
Copy link
Contributor Author

will fix these issues ASAP

@walterbender walterbender merged commit 7911644 into sugarlabs:master Aug 6, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants