feat: implement tuner in the sampler widget

[haroon10725]

@walterbender @pikurasa Before moving on, can you please review the code?
I have implemented the frontend yet.

The colors are constant at the moment, they will be changing w.r.t pitch.

[github-actions]

✅ All Jest tests passed! This PR is ready to merge.

[omsuneri]

@haroon10725 please ignore the lint workflow failure i m working on that you need not to be worry about that

[github-actions]

✅ All Jest tests passed! This PR is ready to merge.

[github-actions]

✅ All Jest tests passed! This PR is ready to merge.

[haroon10725]

[Commanderk3]

@haroon10725
I have set up pitch detection and it is working fine. Perhaps we can be together on this one? With this frontend the tuner will be completed.

[Commanderk3]

My setup shows the offset in cents and we can show that in this meter that you made.

[haroon10725]

@Commanderk3 Yes sure, we can discuss the frontend and pitch detection approach in tomorrow's meet.

[pikurasa]

That looks pretty decent.

I'm not sure that we really need the extra step of having the user click "start tuning" before the feature starts running.

[haroon10725]

That looks pretty decent.

Thanks

I'm not sure that we really need the extra step of having the user click "start tuning" before the feature starts running.

Yes, we can remove that button, allowing users to start by just clicking the tuner icon in the toolbar.

[github-actions]

✅ All Jest tests passed! This PR is ready to merge.

[haroon10725]

@walterbender @pikurasa Now the user can just start and stop the tuner by just clicking the button in the toolbar.
tuner.webm

[haroon10725]

Now I am starting to implement the backend of it. @Commanderk3 you showed some demo for it. Can you please share the code here. May be we can take a look at it and implement it using Tone.js.

I think this was the code, let me go through it https://github.com/cwilso/PitchDetect/blob/main/js/pitchdetect.js

[Commanderk3]

@haroon10725 Yes something like that. YIN uses correlation function and after that a series of other functions to refine the frequency.
I will make a branch and will share it here. Is it okay?

[Commanderk3]

https://github.com/Commanderk3/musicblocks/tree/tuner

[Commanderk3]

I made a draft PR @haroon10725
You may test the branch and let me know your thoughts.

[haroon10725]

I made a draft PR @haroon10725

I think there is no need for it, I got your code. We can continue discussing here only. Don't create separate PRs for the same thing.

[Commanderk3]

Okay, I will close it then.

[haroon10725]

Okay, I will close it then.

Yes it would be easy for the maintainers, I am going through the code which you shared. You can then implement the backend code you shared.

We can use Tone.js to open mic and close. Some of the analysis can also be done through it. Let me see.

@Commanderk3 What do you think about it?

[Commanderk3]

I am confused about how you wanna use Tone here. Did you find anything?
@haroon10725 Did you test my branch?

[haroon10725]

In Tone we have
await Tone.start();
mic = new Tone.UserMedia();
await mic.open();
which opens the mic, futher more we have an analyser function also
analyser = new Tone.Analyser("fft", 2048);
mic.connect(analyser);

Then we can use the YIN algorithm on it.

We can remove the Web Audio API, and use Tone.js. Tone.js also uses Web Audio API under the hood, by doing this our code will be consistent
@walterbender @pikurasa @Commanderk3 What do you think about it.

[farhan-momin]

Now I am starting to implement the backend of it. @Commanderk3 you showed some demo for it. Can you please share the code here. May be we can take a look at it and implement it using Tone.js.

I think this was the code, let me go through it https://github.com/cwilso/PitchDetect/blob/main/js/pitchdetect.js

@haroon10725 Yeah i referred this repo to implement the feature which i demonstrated in meet. Here is the code for the feature 638b82a

Its basically uses an auto-correlate function for for pitch detection.

For the tuner feature we can use any method (YIN or auto-correlate) that works well.

Im currently trying to use tone.js for listening to audio. will update 638b82a when its completed for your reference

[Commanderk3]

Alright, I get it now @haroon10725
Thanks for explaining

[farhan-momin]

Ive made changes to use tone.js for Tuner in https://github.com/farhan-momin/musicblocks/tree/tuner.

I was getting incorrect outputs initially. The argument "fft" in analyser = new Tone.Analyser("fft", 2048); was the reason for it.
The pitch detection algorithm i used is based on Time domain. so i used "waveform" instead.

[walterbender]

What is the status of this PR?

[haroon10725]

What is the status of this PR?

@walterbender Frontend of the tuner is completed, implementing backend and then changing colors w.r.t to pitch has to be implemented.

[github-actions]

✅ All Jest tests passed! This PR is ready to merge.

[pikurasa]

@farhan-momin Should I test again? If so, what should I look out for?

[haroon10725]

@farhan-momin Should I test again? If so, what should I look out for?

@pikurasa I am working on it. Implementing backend. Testing out several algorithms for pitch detection.

[farhan-momin]

@farhan-momin Should I test again? If so, what should I look out for?

@pikurasa This PR is in progress. I suggest testing it after we complete it.

[farhan-momin]

@haroon10725 Please let me know if there is anything else required for integrating backend.

[haroon10725]

@haroon10725 Please let me know if there is anything else required for integrating backend.

@farhan-momin Sure, we can discuss in tomorrow meet.

[github-actions]

This pull request has been open for more than 60 days without any activity. It will be closed in 3 days unless the stale label is removed or commented on.

[github-actions]

Closed pull request due to inactivity for more than 63 days.