-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced Footer. Fixes issue #635. #639
base: master
Are you sure you want to change the base?
Conversation
Great job on your work so far! However, please try to avoid making unnecessary changes, such as adding or removing spaces, as it makes it harder to review the intended changes. I suggest checking the working tree before committing the code to the branch. This will give you an idea of what changes are going to be included in the commit. Also, please write any new CSS in the |
_includes/footer.html
Outdated
(function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){ | ||
(i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o), | ||
m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m) | ||
})(window,document,'script','https://www.google-analytics.com/analytics.js','ga'); | ||
ga('create', 'UA-102776855-1', 'auto'); | ||
ga('send', 'pageview'); | ||
</script> | ||
</script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't remove the newline at end of this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh..really really sorry. It's just a force of habit. I will make sure to change it as soon as I get to my PC.
Made the Footer responsive as per the requirements.
Made a few indentation changes to make the code more readable.