📝(self-hosted) Add step to copy default.conf.template when using nginx-proxy #1201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jco-c
force-pushed
the
main
branch
2 times, most recently
from
46d3a34 to
3c36646
Compare
|
I also added a commit to make the commands copy-pastable by adding the folder-name (e.g. docs, keycloak, etc.) to the curl command. Otherwise I would have to change the directory before executing the curl commands. Please let me know if I should remove that commit :) |
Add step to copy default.conf.template hen using nginx-proxy. Signed-off-by: Jan Conen <[email protected]>
Make bash commands copy-pastable by prepending the foldername to the commands. Signed-off-by: Jan Conen <[email protected]>
AntoLC
added
documentation
AntoLC
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When self-hosting docs, my reverse proxy configuration didn't work as I didn't copy default.conf.template to my docs directory. To prevent this issue for future installations, I want to add a step to the compose docs to copy the default.conf.template file.
This is my first pull request for this project, so please let me know if I did something wrong in this process :)
Proposal
External contributions
Thank you for your contribution! 🎉
Please ensure the following items are checked before submitting your pull request:
git commit --signoff(DCO compliance)git commit -S)<gitmoji>(type) title description## [Unreleased]section (if noticeable change) -> don't think it's needed for such a small change