♿(frontend) improve screen reader support in DocShare modal with aria… #1628
Conversation
Ovgodd
force-pushed
the
fix/a11y-improve-doc-share-sr
branch
from
f0a76cc to
b3e403d
Compare
Ovgodd
force-pushed
the
fix/a11y-improve-doc-share-sr
branch
3 times, most recently
from
a82b0a3 to
5d6ade1
Compare
|
Size Change: +231 B (+0.01%) Total Size: 4.07 MB
|
Ovgodd
force-pushed
the
fix/a11y-improve-doc-share-sr
branch
2 times, most recently
from
9f5ed00 to
1a5281b
Compare
| style={{ | ||
| position: 'absolute', | ||
| left: '-10000px', | ||
| width: '1px', | ||
| height: '1px', | ||
| overflow: 'hidden', | ||
| }} | ||
| > |
There was a problem hiding this comment.
The style attach with sr-only is not enough ?
There was a problem hiding this comment.
oh yes, why I did that.
| // Announce to screen readers | ||
| const userName = user.full_name || user.email; | ||
| setLiveAnnouncement( | ||
| t( | ||
| '{{name}} added to invite list. Add more members or press Tab to select role and invite.', | ||
| { | ||
| name: userName, | ||
| }, | ||
| ), | ||
| ); | ||
| // Clear announcement after it's been read | ||
| setTimeout(() => setLiveAnnouncement(''), 100); | ||
| }; |
There was a problem hiding this comment.
I find a bit strange to do the announcement, we have a notification system, but I think we decided to not display a notification for that, because the invitation list will display the user that you just add, it is already like a announcement.
There was a problem hiding this comment.
I find a bit strange to do the announcement, we have a notification system, but I think we decided to not display a notification for that, because the invitation list will display the user that you just add, it is already like a announcement.
Hey ! the SR announcement is necessary for RGAA compliance. Users with visual "issues"cannot see the visual feedback when a user is added to the invite list. The aria-live region provides audio feedback only (no visual toast, this is a standard accessibility requirement
CHANGELOG.md
Outdated
| - ♿(frontend) improve ARIA in doc grid and editor for a11y #1519 | ||
| - ♿(frontend) improve accessibility and styling of summary table #1528 | ||
| - ♿(frontend) add focus trap and enter key support to remove doc modal #1531 | ||
| - ♿(frontend) improve screen reader support in DocShare modal #1628 |
There was a problem hiding this comment.
During rebase, this part will have to go under Unrelease
adds relevant aria-labels to enhance accessibility for assistive technologies Signed-off-by: Cyril <[email protected]>
Ovgodd
force-pushed
the
fix/a11y-improve-doc-share-sr
branch
from
68c85bf to
0577a34
Compare
Purpose
Improve accessibility in the DocShare modal by enhancing screen reader support.
this fix this issue too
Proposal
ariaLabelprop toDocRoleDropdownfor contextual role change labelsariaLabelinDocShareAccessRequest,Invitation, andMemberitemsDocShareModalfor: