Skip to content

📝 (doc) Fix Markdown in CODE_OF_CONDUCT.md #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

xibe
Copy link

@xibe xibe commented Mar 18, 2025

Purpose

The COC file was visually broken because of some Markdown formatting issues. This PR fixes that, as well as adding links that were missing at the end.

image

Actions

  • Fix Markdown formatting
  • Add link to contributor-covenant.org
  • Add link to Mozilla code of conduct enforcement ladder
  • Fixes small typos

@lunika lunika requested a review from virgile-dev March 18, 2025 13:16
Copy link
Collaborator

@virgile-dev virgile-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey ! Thanks for the improvements.
I'm ready to approve I just need you to squash this into one commit and use the right Gitmoji formating for your comments otherwise you won't pass the CI and I won't be able to merge.
The issue right now is you have space between you emoji and the (
❌ 📝 (doc) Fix Markdown in CODE_OF_CONDUCT.md]
✅ 📝(doc) Fix Markdown in CODE_OF_CONDUCT.md]
Check out the contributing.md and the handbook if you want more details : https://suitenumerique.gitbook.io/handbook

@virgile-dev
Copy link
Collaborator

Oh and also, you need to add an entry in the changelog for your PR otherwise the test won't pass. @xibe let me know if you need any help I'm happy to jump in a video call.

@xibe
Copy link
Author

xibe commented Mar 27, 2025

Sorry, I've been busy. I'll get to the squashing and fixing this week-end.

@virgile-dev
Copy link
Collaborator

Hey @xibe can you squash your commits and use the convention for the one commit you'll keep?
No changelog entry needed for this.
Let me know if I can help.
I recently relearned git rebase, it's not so easy ;)

@xibe
Copy link
Author

xibe commented Apr 7, 2025

Closing this in favor of #849 .
Yes, git rebase is hard :D

@xibe xibe closed this Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants