🏗️(frontend) footer configurable #959
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rule @typescript-eslint/no-unused-vars didn't have a ignore pattern. A ignore pattern can be usefull in some cases.
AntoLC
force-pushed
the
refacto/footer-from-json
branch
from
13b6929 to
24febb9
Compare
Improve config testcases: - let THEME_CUSTOMIZATION_FILE_PATH to be set to check the default value - add helper function overrideConfig
To have different footer per instance the content of the footer is now configurable from the theme customization file. See THEME_CUSTOMIZATION_FILE_PATH env var.
Legal pages are not needed anymore in the application. In the dsfr instances, the legal pages will be displayed on a Docs pages. We let the users of Docs managing the legal pages on their own instances.
AntoLC
force-pushed
the
refacto/footer-from-json
branch
from
24febb9 to
f1d2050
Compare
AntoLC
changed the title
rvveber
reviewed
May 13, 2025
|
|
||
| ### Example of JSON | ||
|
|
||
| The json must follow some rules: https://github.com/suitenumerique/docs/blob/main/src/backend/impress/configuration/theme/default.json |
There was a problem hiding this comment.
To illustrate the rules, can we point it to the demo.json in helm directory instead of the default.json?
Some customizations, like the translations do not make sense to be in default.json (yet).
I've put them in demo.json to illustrate how it is used.
If the user views this documentation, maybe it is better to link to the same json file.
see here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We need to have different footer per instance.
The footer has to be displayable or not.
Proposal
Bind the frontend footer with the theme configuration file:
https://github.com/suitenumerique/docs/blob/main/src/backend/impress/configuration/theme/default.json
Demo