enhance: extract uncommitted non-log load changes#7
Closed
sunby wants to merge 1 commit into
Closed
Conversation
Signed-off-by: sunby <sunbingyi1992@gmail.com>
Owner
Author
|
Superseded by upstream PR milvus-io#50269. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains only the current uncommitted non-log changes from
/home/ubuntu/milvus.Base/head setup:
codex/load-1m-clean-baserebuilds the current local branch context frombceb050835with the non-profile commits2d61809443and4c608294bd.32fa0ede29, which also triggers GitHub push protection fromconfigs/milvus.yaml.codex/uncommitted-nonlog-load-1madds one commit with only the filtered uncommitted non-log changes.Included changes:
pkg/v3/ proto v3 packages.MaxReadConcurrency * CGOPoolSizeRatio.0b35d53.Excluded intentionally:
[sss],[www],[xxx], timing/profile logs.configs/andscripts/.Validation:
git diff --check codex/load-1m-clean-base..codex/uncommitted-nonlog-load-1mpassed.go test -tags dynamic,test -gcflags="all=-N -l" -run '^$' -count=1 ./internal/datacoord ./internal/util/cgo ./internal/flushcommon/writebufferis blocked in this environment becausepkg-configcannot findmilvus_core.pc/milvus-storage.pc.