Skip to content

enhance: extract uncommitted non-log load changes#7

Closed
sunby wants to merge 1 commit into
codex/load-1m-clean-basefrom
codex/uncommitted-nonlog-load-1m
Closed

enhance: extract uncommitted non-log load changes#7
sunby wants to merge 1 commit into
codex/load-1m-clean-basefrom
codex/uncommitted-nonlog-load-1m

Conversation

@sunby

@sunby sunby commented Jun 3, 2026

Copy link
Copy Markdown
Owner

This PR contains only the current uncommitted non-log changes from /home/ubuntu/milvus.

Base/head setup:

  • Base branch codex/load-1m-clean-base rebuilds the current local branch context from bceb050835 with the non-profile commits 2d61809443 and 4c608294bd.
  • It intentionally skips profile/log commit 32fa0ede29, which also triggers GitHub push protection from configs/milvus.yaml.
  • Head branch codex/uncommitted-nonlog-load-1m adds one commit with only the filtered uncommitted non-log changes.

Included changes:

  • Fix new DataCoord/writebuffer files to import pkg/v3 / proto v3 packages.
  • Size the CGO pool from MaxReadConcurrency * CGOPoolSizeRatio.
  • Wait for MVCC timestamp prefetch before filtering.
  • Reduce the prefetch thread pool size from 64 to 24.
  • Update the milvus-storage revision to 0b35d53.

Excluded intentionally:

  • [sss], [www], [xxx], timing/profile logs.
  • trace/requestID-only plumbing used by those logs.
  • local runtime config changes under configs/ and scripts/.
  • untracked artifacts and patch files.

Validation:

  • git diff --check codex/load-1m-clean-base..codex/uncommitted-nonlog-load-1m passed.
  • Log/trace marker scan of the PR diff passed.
  • go test -tags dynamic,test -gcflags="all=-N -l" -run '^$' -count=1 ./internal/datacoord ./internal/util/cgo ./internal/flushcommon/writebuffer is blocked in this environment because pkg-config cannot find milvus_core.pc / milvus-storage.pc.

Signed-off-by: sunby <sunbingyi1992@gmail.com>
@sunby

sunby commented Jun 3, 2026

Copy link
Copy Markdown
Owner Author

Superseded by upstream PR milvus-io#50269.

@sunby sunby closed this Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant