This repository was archived by the owner on Feb 16, 2026. It is now read-only.
14.0 purchase sale inter company notify user#4
Closed
ntsirintanis wants to merge 3 commits into14.0from
Closed
Conversation
ntsirintanis
force-pushed
the
14.0-purchase_sale_inter_company_notify_user
branch
from
f6bd221 to
e58908e
Compare
thomaspaulb
reviewed
Sep 10, 2024
| ), | ||
| ) | ||
| ) | ||
| return purchase.user_id.id |
Member
There was a problem hiding this comment.
This should rather be purchase.company_id.notify_user.id or purchase.user_id.id, I think, so that it can be configured on the target company side.
Author
There was a problem hiding this comment.
I see. So in res.config.settings, I have made notify_user_id a required field, only when notification_side is configured for source company sale.order. So first I should remove this restriction, and then make this change
thomaspaulb
reviewed
Sep 10, 2024
|
|
||
| def _get_user_to_notify(self, purchase): | ||
| """Notify user based on res.config.settings""" | ||
| if self.company_id.notification_side == "so": |
Member
There was a problem hiding this comment.
In the rare case where someone wants different notification sides for different dropshipping companies, maybe this should be purchase.company_id.notification_side instead. So that people can configure it per target company.
Member
|
Integrated within #8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.