New Coalignment API #293
Open
New Coalignment API #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
few fixes in refs fixing the refs
importing funcs testing import i think final final nail explicit imports
Co-authored-by: Nabil Freij <[email protected]>
Co-authored-by: Nabil Freij <[email protected]>
lint
Co-authored-by: Nabil Freij <[email protected]>
Co-authored-by: Nabil Freij <[email protected]>
nabobalis
force-pushed
the
coalign_pr
branch
from
fba5f7c to
694d7bd
Compare
wtbarnes
requested changes
Nov 19, 2025
Comment on lines
113
to
115
| # TODO: Work out what is going on | ||
| if corr.ndim != target_array.ndim: | ||
| raise ValueError("The correlation output failed to work out a match.") |
Member
Author
There was a problem hiding this comment.
I replaced the error message with what I think is happening.
Co-authored-by: Will Barnes <[email protected]>
Co-authored-by: Will Barnes <[email protected]>
Co-authored-by: Will Barnes <[email protected]>
Co-authored-by: Will Barnes <[email protected]>
Co-authored-by: Will Barnes <[email protected]>
Co-authored-by: Will Barnes <[email protected]>
Co-authored-by: Will Barnes <[email protected]>
Co-authored-by: Will Barnes <[email protected]>
Co-authored-by: Will Barnes <[email protected]>
Co-authored-by: Will Barnes <[email protected]>
Co-authored-by: Will Barnes <[email protected]>
nabobalis
force-pushed
the
coalign_pr
branch
5 times, most recently
from
792f2d1 to
240258d
Compare
nabobalis
force-pushed
the
coalign_pr
branch
from
240258d to
01c1344
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I lack write access now, I copied #207 here.
coalignmentmodule #83This should be squash merged