Repository navigation
Adapt to contract that uses v2 permits - #16
Merged
Merged
Conversation
WillSewell
force-pushed
the
adapt-to-contract-that-uses-v2-permits
branch
from
November 14, 2025 17:20
d85ab40 to
09cbaca
Compare
WillSewell
force-pushed
the
adapt-to-contract-that-uses-v2-permits
branch
from
November 14, 2025 17:35
09cbaca to
8e3b70c
Compare
cxkoda
reviewed
Nov 17, 2025
| }) => { | ||
| // TODO: In the future, could also show an example of basic permits without per-entity allocations | ||
| if (!("Permit" in purchasePermitResp.PermitJSON)) { | ||
| if (!("MinPrice" in purchasePermitResp.PermitJSON)) { |
Contributor
There was a problem hiding this comment.
did we already change the example sale config to use the v2 permit?
Comment on lines
3
to
4
| NEXT_PUBLIC_SALE_UUID=c3e73992-d3d3-4c83-8709-d5864221da46 | ||
| NEXT_PUBLIC_OAUTH_CLIENT_UUID=d4301660-d56f-4a1b-ba46-29c909b58dfe |
Contributor
There was a problem hiding this comment.
do these also need to be changed now?
Collaborator
Author
There was a problem hiding this comment.
Not technically for this PR (still pointed at the one shared with megaeth), but they'll get updated when I merge the other PR (based off this one)
cxkoda
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.