Add proof of concept for T.Output() #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Aleks Fazlieva <[email protected]>
jba
reviewed
Oct 2, 2023
src/testing/testing.go
Outdated
| return OutputWriter{c} | ||
| } | ||
|
|
||
| type OutputWriter struct { |
src/testing/testing.go
Outdated
| parent.mu.Lock() | ||
| defer parent.mu.Unlock() | ||
| if !parent.done { | ||
| parent.output = append(parent.output, parent.decorate(str, depth+1)...) |
There was a problem hiding this comment.
This Write method is at a lower level than logDepth. It isn't responsible for adding line info or a final newline, so it shouldn't call decorate. It does need to handle indentation, though. I'm not sure where that happens.
Co-authored-by: Aleks Fazlieva <[email protected]>
suntala
force-pushed
the
suntala/t-output-poc
branch
from
f8a90ab
to
61379e3
Compare
Co-authored-by: Aleks Fazlieva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://go.dev/issue/59928