fix: do not attempt db connection if jsonc section is missing #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juleswritescode
commented
Apr 25, 2025
| @@ -179,21 +179,36 @@ export interface GetCompletionsParams { | |||
| */ | |||
| position: TextSize; | |||
There was a problem hiding this comment.
auto-generated
juleswritescode
commented
Apr 25, 2025
psteinroe
approved these changes
Apr 25, 2025
…_lsp into fix/default-db-connection
…se-community/postgres_lsp into fix/default-db-connection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user did not specify the
dbsection in the jsonc, we would per default try to connect topostgresql://postgres:[email protected]:5432/postgres.The reason is the
biome_serialize_macros::Mergemacro:If two
configuration.dbs areNone, they are merged into aSome(PartialConfiguration {})where all properties areNone; if we then callDatabaseSettings::from(partial_configuration), the partial config is merged withDatabaseSettings::default()– where we specified the above connection settings.We can't really work around that without refactoring the whole configuration shenaigans, so I pulled the
cli_options.skip_dbflag into the database settings.You can still pass it as
postgrestools check --disable-db test.sql, and it is hidden in the.jsonc.When a user does not specify a
db.hostin thejsonc, all db-connections are now disabled.