Skip to content

feat(completions): complete in WITH CHECK and USING clauses #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 50 commits into
base: main
Choose a base branch
from
Open

feat(completions): complete in WITH CHECK and USING clauses #422

wants to merge 50 commits into from

Conversation

juleswritescode
Copy link
Collaborator

No description provided.

@juleswritescode juleswritescode changed the base branch from main to feat/to-role June 6, 2025 17:05
@juleswritescode juleswritescode requested a review from psteinroe June 6, 2025 17:06
juleswritescode
juleswritescode commented Jun 6, 2025
View reviewed changes
crates/pgt_completions/src/providers/functions.rs
assert_complete_results(
query.as_str(),
vec![
// TODO: add procedures, load aggregates but skip them
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was on my way of doing this, but there's a bug in the functions.sql query…… will work on that another day :)

juleswritescode
juleswritescode commented Jun 6, 2025
View reviewed changes
juleswritescode
juleswritescode commented Jun 6, 2025
View reviewed changes
@juleswritescode juleswritescode changed the base branch from feat/to-role to main June 10, 2025 17:42
@juleswritescode juleswritescode enabled auto-merge (squash) June 11, 2025 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psteinroe psteinroe psteinroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juleswritescode @psteinroe