Fix kong permission and execution errors in wrapper.sh#45
Closed
pieveee wants to merge 9 commits intosupabase-community:mainfrom
Closed
Fix kong permission and execution errors in wrapper.sh#45pieveee wants to merge 9 commits intosupabase-community:mainfrom
pieveee wants to merge 9 commits intosupabase-community:mainfrom
Conversation
If the database provided is being disabled in values.yaml (e.g. because of using a replicated database solution) the helm installation would fail with:
Error: INSTALLATION FAILED: template: supabase/templates/db/storage.yaml:1:14: executing "supabase/templates/db/storage.yaml" at <.Values.db.persistence.enabled>: nil pointer evaluating interface {}.enabled
Fix missing if-clause when database is disabled
Currently, the container for kong would not start as wrapper.sh fails in its execution with "Illegal option -o pipefail" (See: https://www.baeldung.com/linux/illegal-option-o-pipefail#how-to-avoid-the-error).
The /home/kong/ directory doesn't exist in the newest Docker image of kong. Hence, the kong.yml should be stored at an existing and writeable directory.
Fix kong permission issues
Change wrapper.sh execution from sh to bash
Contributor
Author
|
@milanvanschaik Can you check the merge request? |
|
@milanvanschaik @bigbitbus @icrotz @cpdeethree @devudopw @kiwicopple could you have a look? |
Contributor
|
I don't have the rights to merge on this repository |
Contributor
Contributor
|
🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Currently, kong fails to start running with the following error:
And:
What is the new behavior?
/bin/shto/bin/bash(See https://www.baeldung.com/linux/illegal-option-o-pipefail)/home/kong/kong.ymlto/usr/local/kong/kong.yml, as well as/home/kong/template.ymlto/usr/local/template.ymlin order to runwrapper.shscript without permission issues