Fix inconsistent outdated oapi-codegen in make dev-deps
#2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avakarev
changed the title
make dev-depsmake dev-deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fix oapi-codegen reference in
make dev-depsWhat is the current behavior?
make dev-depsinstalls outdated inconsistent version v1 of oapi-codegen (rest of codebase uses v2, seetools/tools.goandclient/admin/gen.go)What is the new behavior?
make dev-depsinstalls oapi-codegen v2, same it should beAdditional context
Additionally, the repo
github.com/deepmap/oapi-codegendoesn't exist anymore. Github redirect togithub.com/oapi-codegen/oapi-codegen, so this is the new official pkg repo.