feat: hooks round 4 - update tests to use require package #2030
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hooks Round 4
This PR will contain a series of commits preparing for the implementation of before & after user created hooks. It takes the feedback from #2012 into consideration.
Summary
feat: hooks round 4 - update tests to use require package
require
for tests in: f2b3600internal/e2e/...
internal/hooks/...
Depends on
feat: hooks round 1 - prepare package structure
internal/hooks/v0hooks/v0http
->internal/hooks/hookshttp
8a398abinternal/hooks/v0hooks/v0pgfunc
->internal/hooks/hookspgfunc
8a398abinternal/e2e
for test setup in:internal/hooks/hookspgfunc
4d60288internal/hooks/v0hooks
4a7432bfeat: hooks round 2 - remove indirection and simplify error handling
internal/api
to:internal/hooks/v0hooks.Manager
instead ofinternal/hooks/hooks.Manager
aec5995internal/hooks/hooks.Manager
062da5dinternal/hooks/hookserrors
7e80afcinternal/hooks/hookserrors
ininternal/hooks/v0hooks
57744e8internal/hooks/v0hooks
with anEnabled
method 16cc4c9feat: hooks round 3 - begin adding the Before and After user created hooks
internal/conf
d5f5436BeforeUserCreated
andAfterUserCreated
toHookConfiguration
structEmailValidationBlockedMX
to restore 100% test coverageinternal/hooks/v0hooks
bd37fe2BeforeUserCreated
method tov0hooks.Manager
structAfterUserCreated
method tov0hooks.Manager
structinternal/e2e/e2ehooks
903e623HookCall
to record calls to hooksHook
struct to hold[]*HookCall
for a given hook nameHookRecorder
to hold oneHook
object per hook nameInstance
struct to hold thehttptest.Server
andHookRecorder
AfterUserCreated
method tov0hooks.Manager
structinternal/e2e
packagesinternal/hooks/v0hooks
829aec6internal/hooks/v0hooks
ca67be0BeforeUserCreated
andAfterUserCreated
methodsInvokeHook
internal/e2e/e2eapi
46c144ehttp.RoundTripper
t.Fatal
to userequire