fix: timed_out in net._http_response is always NULL #226
+102
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-chavez
changed the title
2 tasks
steve-chavez
force-pushed
the
fix-timedout
branch
4 times, most recently
from
bc3d24d to
5327999
Compare
steve-chavez
requested review from
laurenceisla and
za-arthur
and removed request for
laurenceisla
za-arthur
reviewed
Aug 20, 2025
steve-chavez
force-pushed
the
fix-timedout
branch
from
5327999 to
ea66c42
Compare
Closes supabase#180. Before: ```sql select net.http_get('http://localhost:8080/pathological?status=200&delay=6', timeout_milliseconds := 1000); http_get ---------- 1 (1 row) postgres=# select timed_out, error_msg from net._http_response ; timed_out | error_msg -----------+----------------------------------------------------------------------------------------------------------------------------------------------------------------- | Timeout of 1000 ms reached. Total time: 1001.461000 ms (DNS time: 0.052000 ms, TCP/SSL handshake time: 0.258000 ms, HTTP Request/Response time: 1001.095000 ms) (1 row) ``` Now: ```sql timed_out | error_msg -----------+----------------------------------------------------------------------------------------------------------------------------------------------------------------- t | Timeout of 1000 ms reached. Total time: 1001.106000 ms (DNS time: 0.038000 ms, TCP/SSL handshake time: 0.176000 ms, HTTP Request/Response time: 1000.856000 ms) (1 row) ``` add polyfill
steve-chavez
force-pushed
the
fix-timedout
branch
from
ea66c42 to
1157dd2
Compare
|
@za-arthur Addressed all the feedback. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #180.
Before:
Now: