-
-
Notifications
You must be signed in to change notification settings - Fork 205
feat: support multiple versions of the pg-graphql extension #1761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to finish rebase and testing
Build multiple versions of the pg_graphql extension on different PostgreSQL versions. Add test for the extensions and their upgrade on PostgreSQL 15 and 17.
This change allows developers to target specific Rust versions for building extensions. It implements support for building cargo extensions and `cargo-pgrx` using the specified Rust version.
1e4a0a9
to
5845593
Compare
The issue we face when building pg_graphql on aarch64 is: `Invalid or unknown abi 16 for function "_ZGVnN4vv_atan2f"` It has been fixed in bindgen 0.11.3.
Add special case handling for 1.5.1-mergeless to 1.5.4 upgrade path. Also replace CREATE FUNCTION with CREATE OR REPLACE FUNCTION to prevent conflicts in migration scripts and the same for event triggers.
pg_graphql 1.5.4 uses pgrx 0.11.3 which fixed the ABI issues on aarch64-linux.
We don't recompile the extension using pgx with dev/debug symbols, but we do run the pg_regress tests to ensure everything is working correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
passing all tests
Build multiple versions of the pg_graphql extension on different PostgreSQL versions.
Add test for the extensions and their upgrade on PostgreSQL 15 and 17.
Make sure we build cargo extension and cargo-pgrx with the specified Rust version.