Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Detached buckets #345

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Feat: Detached buckets #345

wants to merge 4 commits into from

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Jul 4, 2023

What kind of change does this PR introduce?

Feature

What is the new behavior?

Implements linked / detached buckets (naming still to finalize)

You'll be able to create buckets that are linked to an external S3-compatible bucket of your choice.

@fenos fenos force-pushed the feat/detached-buckets branch 2 times, most recently from 79ef47e to f1a3b29 Compare July 5, 2023 10:02
@coveralls
Copy link

coveralls commented Jul 5, 2023

Pull Request Test Coverage Report for Build 5467197486

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 941 of 1273 (73.92%) changed or added relevant lines in 63 files are covered.
  • 74 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-2.1%) to 83.151%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/http/routes/object/getObject.ts 11 12 91.67%
src/http/routes/bucket/createBucket.ts 6 8 75.0%
src/http/routes/bucket/updateBucket.ts 6 8 75.0%
src/http/routes/render/renderPublicImage.ts 14 16 87.5%
src/http/routes/tus/lifecycle.ts 25 27 92.59%
src/http/plugins/jwt.ts 7 10 70.0%
src/http/routes/object/getObjectInfo.ts 28 31 90.32%
src/http/routes/tus/file-store.ts 3 6 50.0%
src/http/plugins/db.ts 19 23 82.61%
src/storage/backend/index.ts 13 18 72.22%
Files with Coverage Reduction New Missed Lines %
src/database/tenant.ts 1 58.05%
src/http/plugins/metrics.ts 1 96.92%
src/http/routes/tus/file-store.ts 1 65.91%
src/queue/events/multipart-upload-completed.ts 1 88.1%
src/storage/backend/index.ts 1 70.97%
src/database/connection.ts 2 91.33%
src/storage/backend/file.ts 2 39.08%
src/test/common.ts 5 92.59%
src/http/routes/tus/index.ts 8 73.9%
src/http/routes/tus/handlers.ts 11 45.94%
Totals Coverage Status
Change from base Build 5398587998: -2.1%
Covered Lines: 7753
Relevant Lines: 9246

💛 - Coveralls

@fenos fenos force-pushed the feat/detached-buckets branch 3 times, most recently from cccb140 to cc92390 Compare July 5, 2023 17:26
@fenos fenos force-pushed the feat/detached-buckets branch 2 times, most recently from bd54dd5 to 06fa09d Compare July 6, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants