Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add gravity support for imgproxy #402

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

egor-romanov
Copy link

What kind of change does this PR introduce?

feat: add gravity param support for imgproxy transformation feature

Additional context

https://github.com/supabase/api-gateway/pull/352

https://imgproxy.net/blog/perfect-cut-smart-image-resizing-with-imgproxy/

@coveralls
Copy link

coveralls commented Dec 4, 2023

Pull Request Test Coverage Report for Build 7103078200

  • 42 of 47 (89.36%) changed or added relevant lines in 2 files are covered.
  • 34 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 84.146%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/storage/renderer/image.ts 41 46 89.13%
Files with Coverage Reduction New Missed Lines %
src/storage/renderer/image.ts 34 79.46%
Totals Coverage Status
Change from base Build 7031108426: 0.0%
Covered Lines: 7564
Relevant Lines: 8918

💛 - Coveralls

@egor-romanov
Copy link
Author

hey @fenos , we also need this one right?

https://github.com/supabase/api-gateway/pull/352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants