Skip to content

fix(auth): make webauthn param optional and move register params to webauthn #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(auth): make webauthn param optional and move register params to webauthn #1765

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions packages/core/auth-js/src/lib/webauthn.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,10 +763,10 @@ export class WebAuthnApi {
rpId = typeof window !== 'undefined' ? window.location.hostname : undefined,
rpOrigins = typeof window !== 'undefined' ? [window.location.origin] : undefined,
signal,
},
} = {},
}: {
factorId: string
webauthn: {
webauthn?: {
rpId?: string
rpOrigins?: string[]
signal?: AbortSignal
Expand Down Expand Up @@ -844,14 +844,18 @@ export class WebAuthnApi {
public async _register(
{
friendlyName,
rpId = typeof window !== 'undefined' ? window.location.hostname : undefined,
rpOrigins = typeof window !== 'undefined' ? [window.location.origin] : undefined,
signal,
webauthn: {
rpId = typeof window !== 'undefined' ? window.location.hostname : undefined,
rpOrigins = typeof window !== 'undefined' ? [window.location.origin] : undefined,
signal,
} = {},
}: {
friendlyName: string
rpId?: string
rpOrigins?: string[]
signal?: AbortSignal
webauthn?: {
rpId?: string
rpOrigins?: string[]
signal?: AbortSignal
}
},
overrides?: Partial<PublicKeyCredentialCreationOptionsFuture>
): Promise<RequestResult<AuthMFAVerifyResponseData, WebAuthnError | AuthError>> {
Expand Down