Skip to content

Conversation

grdsdev
Copy link
Contributor

@grdsdev grdsdev commented Jan 28, 2025

This pull request includes multiple changes to improve code functionality, enhance test coverage, and update dependencies. The most important changes include enabling code coverage in the Xcode scheme, adding new helper methods and extensions, updating the StorageFileApi class, and adding new test cases.

Enhancements to Code Functionality:

Updates to StorageFileApi Class:

Test Coverage Enhancements:

Dependency Updates:

  • Package.swift: Added Mocker and TestHelpers dependencies and included a new resource directory Fixtures.

Deprecated Code Updates:

@coveralls
Copy link

coveralls commented Jan 28, 2025

Pull Request Test Coverage Report for Build 13031517288

Details

  • 40 of 63 (63.49%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+4.2%) to 56.699%

Changes Missing Coverage Covered Lines Changed/Added Lines %
Sources/Storage/Helpers.swift 0 1 0.0%
Sources/Helpers/Codable.swift 13 18 72.22%
Sources/Helpers/HTTP/HTTPFields.swift 6 23 26.09%
Totals Coverage Status
Change from base Build 13006261714: 4.2%
Covered Lines: 4816
Relevant Lines: 8494

💛 - Coveralls

@grdsdev grdsdev marked this pull request as ready for review January 29, 2025 12:51
@grdsdev grdsdev requested a review from dshukertjr January 29, 2025 12:51
@grdsdev grdsdev merged commit ce5cf5f into main Jan 30, 2025
22 checks passed
@grdsdev grdsdev deleted the guilherme/storage-tests branch January 30, 2025 09:53
grdsdev added a commit that referenced this pull request Feb 19, 2025
* test(storage): increase code coverage

* add more tests

* add tests

* more tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants