refactor: deduplicate logic in create extension #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-chavez
commented
May 17, 2025
Pull Request Test Coverage Report for Build 15082336752Details
💛 - Coveralls |
steve-chavez
force-pushed
the
ref-extensions
branch
from
3f93249 to
63e3505
Compare
steve-chavez
commented
May 17, 2025
Comment on lines
+451
to
+471
| if (is_extension_privileged(stmt->extname, privileged_extensions)) { | ||
| bool already_switched_to_superuser = false; | ||
|
|
||
| switch_to_superuser(supautils_superuser, &already_switched_to_superuser); | ||
|
|
||
| run_global_before_create_script(stmt->extname, stmt->options, privileged_extensions_custom_scripts_path); | ||
|
|
||
| run_ext_before_create_script(stmt->extname, stmt->options, privileged_extensions_custom_scripts_path); | ||
|
|
||
| override_create_ext_statement(stmt, total_epos, epos); | ||
|
|
||
| run_process_utility_hook(prev_hook); | ||
|
|
||
| run_ext_after_create_script(stmt->extname, stmt->options, privileged_extensions_custom_scripts_path); | ||
|
|
||
| if (!already_switched_to_superuser) { | ||
| switch_to_original_role(); | ||
| } | ||
|
|
||
| return; | ||
| } |
There was a problem hiding this comment.
This is the main result, the logic can be followed easily now. Just one role switching and one run_process_utility_hook.
The `handle_create_extension` function repeated statements unnecessarily: - switched to superuser multiple times - downgraded to privileged role multiple times The switching only needed to be done one time at the start, and downgrading one time at the end. The same effect is maintained, no tests are broken. Also `run_process_utility_hook` is executed once for the `create extension` logic now. Partly addresses supabase#79.
steve-chavez
force-pushed
the
ref-extensions
branch
from
63e3505 to
8b50f6e
Compare
olirice
approved these changes
May 17, 2025
samrose
approved these changes
May 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
handle_create_extensionfunction repeated statements unnecessarily:The switching only needed to be done one time at the start, and downgrading one time at the end.
The same effect is maintained, no tests are broken.
Also
run_process_utility_hookis now executed once for thecreate extensionlogic.Partly addresses #79.