feat: add array cell type support #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olirice
reviewed
Sep 19, 2024
| @@ -79,6 +79,7 @@ impl From<&HostCell> for GuestCell { | |||
| Self::Timestamptz(v.into_inner() + 946_684_800_000_000) | |||
| } | |||
| HostCell::Json(v) => Self::Json(v.0.to_string()), | |||
| _ => todo!(), | |||
There was a problem hiding this comment.
It's quite big change to add array type support for wasm fdw, so I just mark it as todo to keep this PR simple. Will add the array type to wasm fdw it in another PR.
There was a problem hiding this comment.
todo! can be passed a string which can explain the reasoning for the todo.
imor
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR is to add
Arraycell type support.What is the current behavior?
Currently array cell type isn't supported.
What is the new behavior?
Add below array cell types support to framework.
Additional context
N/A