Skip to content

Conversation

@tanvipandhre
Copy link

No description provided.

@super30admin
Copy link
Owner

Strengths:

  • Correct implementation of both problems with optimal time and space complexity.
  • Good use of helper methods (hash1, hash2) to improve code readability.
  • Clear and concise README explaining the approach.

Areas for Improvement:

  • Consider adding inline comments in the hashset implementation to explain why bucket 0 needs an extra element, as this is a non-obvious edge case.
  • In the min stack implementation, the min variable is redundant since minSt.peek() always gives the current minimum. You could remove min to simplify the code slightly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants