Conversation
Owner
|
Your solution for the Group Anagrams problem is excellent. It correctly groups anagrams by using a frequency array and a dictionary with tuple keys. The time and space complexity are optimal. The code is clean and well-commented. One minor suggestion: remove the print statement at the end of the code. In a coding interview or when submitting to an online judge, the solution should only contain the class and method definitions without any external test calls. This ensures that the code runs without unexpected output. Also, note that in Python, the ord('a') is 97, but you can also use ord('a') to make it more readable. However, using 97 is acceptable. Keep up the good work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.