Skip to content

Solved Hashing-2#2165

Open
pratul2789 wants to merge 1 commit intosuper30admin:masterfrom
pratul2789:master
Open

Solved Hashing-2#2165
pratul2789 wants to merge 1 commit intosuper30admin:masterfrom
pratul2789:master

Conversation

@pratul2789
Copy link

No description provided.

@super30admin
Copy link
Owner

Strengths:

  • The solution for SubarraySumEqualsK is correct and efficient.
  • The code is clean and well-commented, making it easy to understand.
  • The time and space complexity are optimal.

Areas for Improvement:

  • Consider using more descriptive variable names for the dictionary (e.g., prefix_sum_freq instead of d) to enhance readability without comments.
  • Although not necessary, you could add a docstring to the method to describe the parameters and return value.

Note: The student also provided solutions for other problems (ContiguousArray and LongestPalindrome). While these are not the focus of this evaluation, it's good to see that the student is practicing multiple problems. However, ensure that when submitting a solution for a specific problem, the code is isolated to that problem to avoid confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants