-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
increase kMaxSynthGrains in JoshGrainUGens #261
base: main
Are you sure you want to change the base?
Conversation
thanks @dyfer - there is, actually, and we do it in the main line grain UGens that were based on these UGens. Basically, you add a parameter in the UGen that lets the user pass in the max number of grains, and RTAlloc the space for them. That is a big change to THESE UGens though and may break backward compatibility. You can see an example from this page: https://github.com/supercollider/supercollider/blob/develop/server/plugins/GrainUGens.cpp
Notice the RTAlloc in next_k IF this is the first run. The value is read from the UGen input, then allocated. I'd suggest first seeing if something similar can be done without breaking backward compatibility, and if so, that would be a better fix. If backward compatibility would be broken, I'm fine with what you have already submitted.... please let me know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see main comment on thread and let me know what you think.
Thanks @joshpar I'll look into it. |
bump @dyfer |
Occasionally I am running into exceeding the number of grains.
This just arbitrarily
exceedsincreases the maximum, but maybe there is a better way to do this?