Repository navigation
docs: correct the 0.9.0 NATS restart and admin-token notes - #8
Merged
Merged
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects two details in the "Upgrading to SIE 0.9.0" section, checked against the chart 0.9.0 README and templates.
nats.auth.allowAnonymousupgrade avoids losing work. The chart README says the upgrade still restarts NATS, so with the default memory-backed work queues, queued and in-flight work is lost. The two steps only close the window in which NATS refuses pods that have not been replaced yet, when requests can fail with503. The bullet now says both, and notes that between the two steps NATS accepts anonymous clients with unrestricted permissions while the chart ships no NetworkPolicy for the NATS pods, so only trusted workloads should reach NATS.sie-cluster-config-admin-token.values-gke.yamlsetsfullnameOverride: sie, so for the install command in this README the Secrets aresie-config-admin-tokenandsie-config-read-token. The bullet now names both and shows how to read the admin token (keySIE_ADMIN_TOKEN, the chart default forconfig.auth.adminTokenSecretKey).kubectl -n sie port-forward svc/sie-gateway 8080:8080after the note that the GKE values file creates no Ingress. The chart names the gateway Service<fullname>-gatewayand listens on port 8080 by default.Documentation only.
terraform fmt -check -recursivepasses.Summary by CodeRabbit
/v1/configsrequest.