Skip to content

docs: correct the 0.9.0 NATS restart and admin-token notes - #8

Merged
mamayer19 merged 1 commit into
mainfrom
docs/0.9.0-upgrade-notes
Oct 1, 2026
Merged

mamayer19 merged 1 commit into
mainfrom
docs/0.9.0-upgrade-notes

Conversation

@krisztian-gajdar

@krisztian-gajdar krisztian-gajdar commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Corrects two details in the "Upgrading to SIE 0.9.0" section, checked against the chart 0.9.0 README and templates.

  • NATS restart. The previous wording implied that the two-step nats.auth.allowAnonymous upgrade avoids losing work. The chart README says the upgrade still restarts NATS, so with the default memory-backed work queues, queued and in-flight work is lost. The two steps only close the window in which NATS refuses pods that have not been replaced yet, when requests can fail with 503. The bullet now says both, and notes that between the two steps NATS accepts anonymous clients with unrestricted permissions while the chart ships no NetworkPolicy for the NATS pods, so only trusted workloads should reach NATS.
  • sie-config tokens. The note did not say how to read the admin token, and the linked chart section uses sie-cluster-config-admin-token. values-gke.yaml sets fullnameOverride: sie, so for the install command in this README the Secrets are sie-config-admin-token and sie-config-read-token. The bullet now names both and shows how to read the admin token (key SIE_ADMIN_TOKEN, the chart default for config.auth.adminTokenSecretKey).
  • Gateway access. Adds kubectl -n sie port-forward svc/sie-gateway 8080:8080 after the note that the GKE values file creates no Ingress. The chart names the gateway Service <fullname>-gateway and listens on port 8080 by default.

Documentation only. terraform fmt -check -recursive passes.

Summary by CodeRabbit

  • Documentation
    • Added instructions for accessing the gateway without an Ingress.
    • Expanded SIE 0.9.0 upgrade guidance, including the effects of NATS authentication, temporary anonymous access, and potential work loss during the first upgrade step.
    • Clarified the admin and read token guidance, including how to retrieve the admin token and the requirement to include a token in every /v1/configs request.

@krisztian-gajdar
krisztian-gajdar requested a review from a team October 1, 2026 08:45
@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: ed4ea123-9857-4a21-852f-19dcf6325cfe

📥 Commits

Reviewing files that changed from the base of the PR and between 049bfa0 and 27121c5.

📒 Files selected for processing (1)
  • README.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@mamayer19
mamayer19 merged commit aafd722 into main Oct 1, 2026
1 of 2 checks passed
@mamayer19
mamayer19 deleted the docs/0.9.0-upgrade-notes branch October 1, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants