Skip to content

Show graph stats summary after watch generates initial files #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greynewell merged 3 commits into from
Apr 7, 2026
+86 −10
Merged

Show graph stats summary after watch generates initial files #55

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe97ffa
Show graph stats summary after watch generates initial files
greynewell Apr 7, 2026
6fa1193
Fix goimports: remove stray blank line in daemon.go
greynewell Apr 7, 2026
570852a
Address CodeRabbit review: dead function count, label fix
greynewell Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 23 additions & 8 deletions internal/files/daemon.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,10 @@
FSWatch bool
PollInterval time.Duration
LogFunc func(string, ...interface{})
OnReady func()
// OnReady is called once after the initial generate completes.
OnReady func(GraphStats)
// OnUpdate is called after each incremental update completes.
OnUpdate func(GraphStats)
}

// Daemon watches for file changes and keeps sidecars fresh.
Expand All @@ -35,9 +38,10 @@
cache *Cache
logf func(string, ...interface{})

mu sync.Mutex
ir *api.SidecarIR
notifyCh chan string
mu sync.Mutex
ir *api.SidecarIR
notifyCh chan string
loadedCache bool // true if startup data came from local cache
}

// NewDaemon creates a daemon with the given config and API client.
Expand Down Expand Up @@ -70,6 +74,11 @@
if err := d.loadOrGenerate(ctx); err != nil {
return fmt.Errorf("startup: %w", err)
}

d.mu.Lock()
stats := computeStats(d.ir, d.cache)
stats.FromCache = d.loadedCache
d.mu.Unlock()
d.writeStatus(fmt.Sprintf("ready — %s — %d nodes",
time.Now().Format(time.RFC3339), len(d.ir.Graph.Nodes)))

Expand All @@ -90,7 +99,7 @@
d.logf("[step:3] Ready — listening on UDP :%d (debounce %s)", d.cfg.NotifyPort, d.cfg.Debounce)
}
if d.cfg.OnReady != nil {
d.cfg.OnReady()
d.cfg.OnReady(stats)
}

var (
Expand Down Expand Up @@ -147,6 +156,7 @@
d.ir = &ir
d.cache = NewCache()
d.cache.Build(&ir)
d.loadedCache = true
d.mu.Unlock()

files := d.cache.SourceFiles()
Expand All @@ -164,6 +174,7 @@
return d.fullGenerate(ctx)
}


Check failure on line 177 in internal/files/daemon.go

View workflow job for this annotation

GitHub Actions / golangci-lint 

File is not properly formatted (goimports)
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Lint is failing on formatting in this file.

Pipeline shows goimports failure at Line 177; please run goimports (or gofmt + import fix) on this file before merge.

🧰 Tools
🪛 GitHub Actions: Lint

[error] 177-177: golangci-lint (goimports): File is not properly formatted (goimports check failed).

🪛 GitHub Check: golangci-lint

[failure] 177-177:
File is not properly formatted (goimports)

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@internal/files/daemon.go` at line 177, The lint failure is due to
formatting/import ordering in daemon.go; run goimports (or gofmt + goimports) on
that file to fix formatting and organize imports, then re-run the linter; ensure
the resulting changes update the package declarations and any functions/types in
daemon.go (e.g., the Daemon type or package daemon top-level declarations) so
the file compiles and the goimports error at the reported location is resolved.

// fullGenerate does a complete fetch + render.
func (d *Daemon) fullGenerate(ctx context.Context) error {
d.logf("Fetching full graph from Supermodel API...")
Expand Down Expand Up @@ -241,16 +252,20 @@

d.logf("Updated %d sidecars", written)

var nodeCount int
var updateStats GraphStats
func() {
d.mu.Lock()
defer d.mu.Unlock()
d.saveCache()
nodeCount = len(d.ir.Graph.Nodes)
updateStats = computeStats(d.ir, d.cache)
}()

d.writeStatus(fmt.Sprintf("ready — %s — %d nodes",
time.Now().Format(time.RFC3339), nodeCount))
time.Now().Format(time.RFC3339), updateStats.SourceFiles))
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Status text/value mismatch: writes “nodes” but stores file count.

At Line 264, the %d argument is updateStats.SourceFiles, but the message says “nodes”. This makes status output inaccurate for downstream readers.

💡 Proposed fix 
-	d.writeStatus(fmt.Sprintf("ready — %s — %d nodes",
-		time.Now().Format(time.RFC3339), updateStats.SourceFiles))
+	d.writeStatus(fmt.Sprintf("ready — %s — %d files",
+		time.Now().Format(time.RFC3339), updateStats.SourceFiles))
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
d.writeStatus(fmt.Sprintf("ready — %s — %d nodes",
time.Now().Format(time.RFC3339), nodeCount))
time.Now().Format(time.RFC3339), updateStats.SourceFiles))
d.writeStatus(fmt.Sprintf("ready — %s — %d files",
time.Now().Format(time.RFC3339), updateStats.SourceFiles))
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@internal/files/daemon.go` around lines 263 - 264, The status string passed to
d.writeStatus is inconsistent: it uses updateStats.SourceFiles but the message
says "nodes"; update the format string or the value so they match—either change
the literal "nodes" to "files" in the call to d.writeStatus or replace
updateStats.SourceFiles with the correct node count field (e.g.,
updateStats.Nodes) so the reported label matches the numeric value; locate the
call to d.writeStatus and the updateStats struct usage to make the fix.


if d.cfg.OnUpdate != nil {
d.cfg.OnUpdate(updateStats)
}
}

// saveCache writes the current merged SidecarIR to the cache file. Must be called with d.mu held.
Expand Down
25 changes: 25 additions & 0 deletions internal/files/graph.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,31 @@ type Cache struct {
FileDomain map[string]string // filePath → domain name
}

// GraphStats summarises what was mapped after a generate or incremental update.
type GraphStats struct {
SourceFiles int
Functions int
Relationships int
FromCache bool // true when data was loaded from a local cache
}
Comment on lines +48 to +55
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

GraphStats is missing issue-requested health metrics.

The linked objective calls for cycle/dead-function visibility, but the new stats shape only includes files/functions/relationships. That leaves the feature partially delivered for the requested summary.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@internal/files/graph.go` around lines 48 - 54, GraphStats is missing health
metrics for cycles and dead functions; extend the GraphStats struct by adding
fields to capture cycle and dead-function visibility (e.g., CycleCount int,
DeadFunctionCount int, and optionally DeadFunctionNames []string or Cycles
[][]string as appropriate for your consumers), then update all places that
construct/populate GraphStats (functions that return or aggregate GraphStats) to
compute and set these new fields and ensure any JSON/serialization usage is
updated to include them (look for usages of the GraphStats type and builders
that set SourceFiles/Functions/Relationships/FromCache).


// computeStats derives a GraphStats from a SidecarIR and its built Cache.
func computeStats(ir *api.SidecarIR, c *Cache) GraphStats {
s := GraphStats{
Relationships: len(ir.Graph.Relationships),
}
for _, n := range ir.Graph.Nodes {
switch {
case n.HasLabel("File"):
s.SourceFiles++
case n.HasLabel("Function"):
s.Functions++
}
}
_ = c // reserved for future per-file breakdown
return s
}
Comment on lines +57 to +74
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

SourceFiles count can drift from actual “source files” shown elsewhere.

At Line 63-66, counting raw "File" labels from IR can include nodes that aren’t renderable source files, while the codebase already defines canonical source-file filtering via Cache.SourceFiles(). This can produce misleading watch summaries.

💡 Proposed fix 
 func computeStats(ir *api.SidecarIR, c *Cache) GraphStats {
 	s := GraphStats{
 		Relationships: len(ir.Graph.Relationships),
 	}
-	for _, n := range ir.Graph.Nodes {
+	if c != nil {
+		s.SourceFiles = len(c.SourceFiles())
+	}
+	for _, n := range ir.Graph.Nodes {
 		switch {
-		case n.HasLabel("File"):
-			s.SourceFiles++
 		case n.HasLabel("Function"):
 			s.Functions++
 		}
 	}
-	_ = c // reserved for future per-file breakdown
 	return s
 }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
// computeStats derives a GraphStats from a SidecarIR and its built Cache.
func computeStats(ir *api.SidecarIR, c *Cache) GraphStats {
s := GraphStats{
Relationships: len(ir.Graph.Relationships),
}
for _, n := range ir.Graph.Nodes {
switch {
case n.HasLabel("File"):
s.SourceFiles++
case n.HasLabel("Function"):
s.Functions++
}
}
_ = c // reserved for future per-file breakdown
return s
}
// computeStats derives a GraphStats from a SidecarIR and its built Cache.
func computeStats(ir *api.SidecarIR, c *Cache) GraphStats {
s := GraphStats{
Relationships: len(ir.Graph.Relationships),
}
if c != nil {
s.SourceFiles = len(c.SourceFiles())
}
for _, n := range ir.Graph.Nodes {
switch {
case n.HasLabel("Function"):
s.Functions++
}
}
return s
}
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@internal/files/graph.go` around lines 56 - 71, computeStats currently counts
nodes with the "File" label directly (in the loop over ir.Graph.Nodes) which can
include non-renderable files; instead use the canonical source-file list from
the cache by calling Cache.SourceFiles() to populate GraphStats.SourceFiles
(e.g., set s.SourceFiles = len(c.SourceFiles())) and remove the manual "File"
label increment; ensure you still handle a nil Cache pointer if c can be nil
before calling c.SourceFiles().


// NewCache creates an empty Cache.
func NewCache() *Cache {
return &Cache{
Expand Down
30 changes: 30 additions & 0 deletions internal/files/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,15 @@ import (
"github.com/supermodeltools/cli/internal/ui"
)

// ANSI helpers used only for watch summary output.
const (
ansiReset = "\033[0m"
ansiBold = "\033[1m"
ansiGreen = "\033[32m"
ansiBGreen = "\033[1;32m"
ansiDim = "\033[2m"
)

// GenerateOptions configures the generate command.
type GenerateOptions struct {
Force bool
Expand Down Expand Up @@ -161,6 +170,27 @@ func Watch(ctx context.Context, cfg *config.Config, dir string, opts WatchOption
FSWatch: opts.FSWatch,
PollInterval: pollInterval,
LogFunc: logf,
OnReady: func(s GraphStats) {
src := "fetched"
if s.FromCache {
src = "cached"
}
fmt.Printf("\n %s✓%s %s%d files%s · %s%d functions%s · %s%d relationships%s %s(%s)%s\n\n",
ansiBGreen, ansiReset,
ansiBold, s.SourceFiles, ansiReset,
ansiBold, s.Functions, ansiReset,
ansiBold, s.Relationships, ansiReset,
ansiDim, src, ansiReset,
)
},
OnUpdate: func(s GraphStats) {
fmt.Printf(" %s✓%s Updated — %s%d files%s · %s%d functions%s · %s%d relationships%s\n",
ansiGreen, ansiReset,
ansiBold, s.SourceFiles, ansiReset,
ansiBold, s.Functions, ansiReset,
ansiBold, s.Relationships, ansiReset,
)
},
}

d := NewDaemon(daemonCfg, client)
Expand Down
Loading