feat: separate dash0 onNotification trigger into onAlertNotification trigger and onSyntheticCheckNotification trigger#3336
Open
felixgateru wants to merge 4 commits intosuperplanehq:mainfrom
Conversation
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on March 12. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
forestileao
reviewed
Mar 2, 2026
felixgateru
force-pushed
the
fix/dash0-notifications
branch
from
ec2b51f to
8338a3f
Compare
…port Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
felixgateru
changed the title
Collaborator
|
@felixgateru works well. @WashingtonKK can you do code review please? |
AleksandarCole
added
pr:stage-3/3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #3321
What changed:
This PR separates the current onNotification trigger into the onAlertNotification and onSyntheticCheckNotification triggers to handle the emitted payloads separately.
Why:
There is a mismatch between the webhook payload for the two notification types.
How:
The pr replicates the existing logic for onNotification into the two triggers.
A guard is added on each trigger to only accept either alert notifications or synthetic check notifications.
The UI mappers are updated for the change.
Related issues:
Fixes: #3321
Demo:
https://www.youtube.com/watch?v=TD0mBZJxeRM