Skip to content

feat: Canvas Settings Page#3397

Merged
forestileao merged 9 commits intomainfrom
feat/canvas-settings-page
Mar 9, 2026
Merged

feat: Canvas Settings Page#3397
forestileao merged 9 commits intomainfrom
feat/canvas-settings-page

Conversation

@forestileao
Copy link
Collaborator

Changes:

Added Canvas Settings page with the following changes:

  • Change name/description (note that rename doesn't work now)
  • Turn on/off versioning
  • Let's not call it sandbox mode
  • Whatever is in org settings should be a default state for new Canvases
  • Fix the links so they are actual links and not JS
  • deleting a Canvas should not try to open it

Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>
Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>
Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>
Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>
@superplanehq-integration
Copy link

👋 Commands for maintainers:

  • /sp start - Start an ephemeral machine (takes ~30s)
  • /sp stop - Stop a running machine (auto-executed on pr close)

Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>
Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>
@shiroyasha
Copy link
Collaborator

Should we add some tests for this? 🤔
Doesn't feel right that we haven't covered it at all.

@forestileao
Copy link
Collaborator Author

@shiroyasha I will add e2e tests

Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>
Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>
Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>
@forestileao
Copy link
Collaborator Author

Updated to correct behavior:

Org canvas versioning ON => all canvases effectively ON.
Org canvas OFF => canvas can still be ON/OFF

Decision made based on 2MFA security enforcements

@forestileao forestileao merged commit ac30abe into main Mar 9, 2026
3 checks passed
@forestileao forestileao deleted the feat/canvas-settings-page branch March 9, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants