Merged
Conversation
|
👋 Commands for maintainers:
|
shiroyasha
reviewed
Mar 9, 2026
shiroyasha
reviewed
Mar 9, 2026
shiroyasha
reviewed
Mar 9, 2026
shiroyasha
reviewed
Mar 9, 2026
shiroyasha
reviewed
Mar 9, 2026
shiroyasha
reviewed
Mar 9, 2026
shiroyasha
reviewed
Mar 9, 2026
Collaborator
|
Overall, good PR 👍 Please add at least some e2e tests to cover the major parts (good yaml, yaml errors, quickfix application, completly broken yaml). There are a lot of moving parts in this PR, it will be super easy to break it if we have no tests for it. |
Collaborator
Author
|
@shiroyasha thanks for the review. I ended up keeping the |
AleksandarCole
force-pushed
the
feat--yaml-preview
branch
from
a307079 to
c444673
Compare
Collaborator
Author
|
/sp start |
|
✅ Ready. Web: https://pr-3400-ephemeral.superplane.com |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a YAML preview allowing users to understand the YAML structure of the Canvas they are editing.