Skip to content

Conversation

@bcbogdan
Copy link

@bcbogdan bcbogdan commented Oct 3, 2025

Summary of change

Updates the token exchange endpoint to return the proper error response when a refresh token is invalid. As per the OAuth2 spec

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • If new thirdparty provider is added,
    • update switch statement in recipe/thirdparty/providers/configUtils.ts file, createProvider function.
    • add an icon on the user management dashboard.
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the add-ts-no-check.js file to include that
  • If added a new recipe / api interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If added a new recipe, then make sure to expose it inside the recipe folder present in the root of this repo. We also need to expose its types.
  • If added a new entry point, then make sure that it is importable by adding it to the exports in package.json

Remaining TODOs for this PR

  • Item1
  • Item2

@netlify
Copy link

netlify bot commented Oct 3, 2025

Deploy Preview for precious-marshmallow-968a81 canceled.

Name Link
🔨 Latest commit e4cd96c
🔍 Latest deploy log https://app.netlify.com/projects/precious-marshmallow-968a81/deploys/68df7ce14f8a8a00080b3fa0

@netlify
Copy link

netlify bot commented Oct 3, 2025

Deploy Preview for astounding-pegasus-21c111 canceled.

Name Link
🔨 Latest commit e4cd96c
🔍 Latest deploy log https://app.netlify.com/projects/astounding-pegasus-21c111/deploys/68df7ce1051cc300081db849

@bcbogdan bcbogdan requested a review from porcellus October 10, 2025 08:59
@porcellus porcellus changed the base branch from master to 23.1 October 10, 2025 09:15
Copy link
Collaborator

@porcellus porcellus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add changelog and rebuild (plus commit the build output)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants