Skip to content

fix: Use correct recipeUserId when registering a WebAuthn credential #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 23.1
Choose a base branch
from
Open

fix: Use correct recipeUserId when registering a WebAuthn credential #1032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions lib/build/recipe/webauthn/api/implementation.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 9 additions & 10 deletions lib/ts/recipe/webauthn/api/implementation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1078,29 +1078,28 @@ export default function getAPIImplementation(): APIInterface {
return generatedOptions;
}

const email = generatedOptions.email;
if (email !== loginMethod.email) {
return {
status: "GENERAL_ERROR",
message: "Email mismatch",
};
}

// NOTE: Following checks will likely never throw an error as the
// check for type is done in a parent function but they are kept
// here to be on the safe side.
if (!email) {
if (!generatedOptions.email) {
throw new Error(
"Should never come here since we already check that the email value is a string in validateEmailAddress"
);
}

if (generatedOptions.email !== loginMethod.email) {
return {
status: "GENERAL_ERROR",
message: "Email mismatch",
};
}

// we are using the email from the register options
const registerCredentialResponse = await options.recipeImplementation.registerCredential({
webauthnGeneratedOptionsId,
credential,
userContext,
recipeUserId: session.getRecipeUserId().getAsString(),
recipeUserId,
});

if (registerCredentialResponse.status !== "OK") {
Expand Down
Loading