-
Notifications
You must be signed in to change notification settings - Fork 89
feat: user management support API types #944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 21.0
Are you sure you want to change the base?
Conversation
Deploying supertokens-node-pr-check-for-edge-function-compat with
|
| Latest commit: |
ed648ed
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3f0a1ab0.supertokens-node-b95.pages.dev |
| status: "EMAIL_ALREADY_EXISTS_ERROR"; | ||
| } | ||
| | GeneralErrorResponse | ||
| >); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try out (emailverification in required mode, and account linking switched on):
- First factor is passwordless -> login with email A, then call the signUpPOST API with email A and some password and the access token of the session. See what happens.
- First factor is passwordless -> login with email A, mark email A as unverified, then call the signUpPOST API with email A and some password and the access token of the session. See what happens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This API can be called when setting a password for an existing account that has no email password login method.
lib/ts/recipe/emailpassword/types.ts
Outdated
| newPassword: string; | ||
| oldPassword?: string; | ||
| }; | ||
| session: SessionContainerInterface; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
session verification here should not have overrideGlobalClaimValidators: () => [] in our api implementation
Summary of change
This PR defines the types for API interface for user management related functionality.
Related issues
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
coreDriverInterfaceSupported.jsonfile has been updated (if needed)lib/ts/version.tsfrontendDriverInterfaceSupported.jsonfile has been updated (if needed)package.jsonpackage-lock.jsonlib/ts/version.tsnpm run build-prettyrecipe/thirdparty/providers/configUtils.tsfile,createProviderfunction.git tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.add-ts-no-check.jsfile to include thatsomeFunc: function () {..}).exportsinpackage.json