Improve error handling, documentation, and failure-path test coverage#14
Merged
Improve error handling, documentation, and failure-path test coverage#14
Conversation
Replace all generic `Error` throws with `OrmError` or `TypeParseError` across the codebase, and export both error classes from the public API so consumers can catch ORM-specific errors distinctly.
Document which error class each method can throw so consumers can discover the error contract without reading source code.
Cover untested error scenarios: InsertQuery builder validation (fields/values conflicts, row mismatch, ignore/onDuplicate conflicts), transaction rollback on callback errors, and batch error propagation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OrmErrorandTypeParseErrorclasses instead of genericError, and export both from the public API so consumers can catch ORM-specific errors distinctly.@throwsJSDoc tags to every method and function that can throw, across query builders, schema, type classes, and utility modules.