Fix zero-value pagination, composite CREATE ids, and batched RETURN DIFF parsing#18
Open
cnpap wants to merge 1 commit intosurrealdb:mainfrom
Open
Fix zero-value pagination, composite CREATE ids, and batched RETURN DIFF parsing#18cnpap wants to merge 1 commit intosurrealdb:mainfrom
cnpap wants to merge 1 commit intosurrealdb:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes three query-builder edge cases and adds focused unit coverage in the existing query test files.
Changes:
LIMIT 0andSTART 0instead of dropping them due to truthy checksRecordIdValueinputs increate(tb, id)instead of stringifying themBatchQuery.execute()reuse the same result handling as single-query execution forRETURN DIFFTests were added to:
tests/unit/query/select.test.tstests/unit/query/create.test.tstests/unit/query/batch.test.ts