Updated project settings + minor code cleanup

sveinbjornt · Sep 22, 2020 · 1ef0428 · 1ef0428
1 parent 7094864
commit 1ef0428
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 16 deletions.
diff --git a/FastDMG.xcodeproj/project.pbxproj b/FastDMG.xcodeproj/project.pbxproj
@@ -114,7 +114,7 @@
 		F45AC0F020ACDB4D0086DF1D /* Project object */ = {
 			isa = PBXProject;
 			attributes = {
-				LastUpgradeCheck = 1140;
+				LastUpgradeCheck = 1200;
 				ORGANIZATIONNAME = "Sveinbjorn Thordarson";
 				TargetAttributes = {
 					F45AC0F720ACDB4E0086DF1D = {
@@ -231,6 +231,7 @@
 				CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
 				CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
 				CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
+				CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
 				CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
 				CLANG_WARN_STRICT_PROTOTYPES = YES;
 				CLANG_WARN_SUSPICIOUS_MOVE = YES;
@@ -243,7 +244,7 @@
 				DEBUG_INFORMATION_FORMAT = dwarf;
 				DEPLOYMENT_POSTPROCESSING = YES;
 				ENABLE_STRICT_OBJC_MSGSEND = YES;
-				ENABLE_TESTABILITY = NO;
+				ENABLE_TESTABILITY = YES;
 				GCC_C_LANGUAGE_STANDARD = "compiler-default";
 				GCC_DYNAMIC_NO_PIC = NO;
 				GCC_NO_COMMON_BLOCKS = YES;
@@ -294,6 +295,7 @@
 				CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
 				CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
 				CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
+				CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
 				CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
 				CLANG_WARN_STRICT_PROTOTYPES = YES;
 				CLANG_WARN_SUSPICIOUS_MOVE = YES;
@@ -329,7 +331,7 @@
 			isa = XCBuildConfiguration;
 			buildSettings = {
 				CODE_SIGN_ENTITLEMENTS = "";
-				CODE_SIGN_IDENTITY = "Developer ID Application";
+				CODE_SIGN_IDENTITY = "Apple Development";
 				CODE_SIGN_STYLE = Manual;
 				DEVELOPMENT_TEAM = 5WX26Y89JP;
 				ENABLE_HARDENED_RUNTIME = YES;
@@ -346,7 +348,7 @@
 			isa = XCBuildConfiguration;
 			buildSettings = {
 				CODE_SIGN_ENTITLEMENTS = "";
-				CODE_SIGN_IDENTITY = "Developer ID Application";
+				CODE_SIGN_IDENTITY = "Apple Development";
 				CODE_SIGN_STYLE = Manual;
 				DEVELOPMENT_TEAM = 5WX26Y89JP;
 				ENABLE_HARDENED_RUNTIME = YES;

diff --git a/FastDMG.xcodeproj/xcuserdata/sveinbjorn.xcuserdatad/xcschemes/FastDMG.xcscheme b/FastDMG.xcodeproj/xcuserdata/sveinbjorn.xcuserdatad/xcschemes/FastDMG.xcscheme
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1140"
+   LastUpgradeVersion = "1200"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

diff --git a/FastDMG/FastDMGAppDelegate.m b/FastDMG/FastDMGAppDelegate.m
@@ -157,17 +157,14 @@ - (void)mountDiskImage:(NSString *)diskImagePath {
         task.launchPath = @"/usr/bin/hdiutil"; // present on all macOS systems
 
         // See man hdiutil for details
-        NSMutableArray *args = [@[@"attach",
-                                  diskImagePath,
-                                  @"-plist",
-                                  @"-noautoopen",
-                                  @"-noautofsck",
-                                  @"-noverify",
-                                  @"-ignorebadchecksums",
-                                  @"-noidme"]
-                                mutableCopy];
-
-        task.arguments = args;
+        task.arguments = @[@"attach",
+                           diskImagePath,
+                           @"-plist",
+                           @"-noautoopen",
+                           @"-noautofsck",
+                           @"-noverify",
+                           @"-ignorebadchecksums",
+                           @"-noidme"];
 
         // STDIN
         task.standardInput = [NSPipe pipe];