Skip to content

Conversation

jycouet
Copy link
Contributor

@jycouet jycouet commented Sep 18, 2025

pnpm-workspace.yaml

Closes: #521
Closes: #705
Closes: #714

tests

Proposal to change how tests are organized (to speedup tests again ^^)

  • variant + kind = flavor AddonTestCase
  • setupTest prepare the test mono repo with all flavors and only one install is needed
  • remove ps-tree dep

On my machine (windows & wsl), add-ons part is going 30% faster!

Copy link

changeset-bot bot commented Sep 18, 2025

🦋 Changeset detected

Latest commit: c97827d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Sep 18, 2025

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/sv@717
npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@717

commit: c97827d

…ltejs#718)

* fix(tailwindcss): add `@tailwindcss/oxide` to approve-builds in `pnpm`

* addd yaml utils

* using yaml-workspace when possible

* windows robustness

* CI debug

* more logs

* !silent

* CI & windows & I don't know

* sniff

* .

* more and more logs

* pnpm v

* cleanup!

* --silent

* add changeset
@jycouet jycouet marked this pull request as draft September 24, 2025 18:32
@jycouet jycouet changed the title chore(cli): speedup internal tests v2 feat(cli): pnpm config in pnpm-workspace.yaml (& update tests) Sep 26, 2025
@jycouet jycouet marked this pull request as ready for review September 26, 2025 18:50
@jycouet
Copy link
Contributor Author

jycouet commented Sep 30, 2025

Some info (I thought I wrote it somewhere, but can't find it)

Before this PR tests structure looks like:

test/add-on-y
  package.json
  pnpm-workspace.yaml
  node_modules
    ...
  12345_0
    package.json
    ...
  12345_1
    package.json
    ...
  12345_2
    package.json
    ...
  12345_3
    package.json
    ...

And the process is:
1/ createpnpm-workspace.yaml
2/ concurrently

  • pnpm i in each project folder 12345_0, 12345_1, ... adding stuff in the shared node_modules.
  • build & tests

After this PR tests structure looks like:

test/add-on-y
  package.json
  pnpm-workspace.yaml
  node_modules
    ...
  default-kit-js
    package.json
    ...
  default-kit-ts
    package.json
    ...
  default-vite-js
    package.json
    ...
  default-vite-ts
    package.json
    ...

1/ createpnpm-workspace.yaml
2/ pnpm i at add-on-y level... once.
3/ concurrently

  • build & tests

@jycouet jycouet requested a review from AdrianGonz97 October 3, 2025 06:44
Copy link
Member

@manuel3108 manuel3108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Will leave it to Adrian to leave the final approval, he has been way more involved in the tests recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants